[12.x] Clean up queue pausing #57863
Conversation
|
edit: I misread the warnings as errors. Was a flaky test, for which I created a separate PR to fix. #57864 |
| * @var list<string> | ||
| */ | ||
| protected $description = 'Resume job processing for a paused queue'; | ||
| protected $aliases = ['queue:continue']; |
There was a problem hiding this comment.
is two command with same names realy needed?
here was just renaming one command to other. d8cbad4
maybe having two commands is some merging mistake?
There was a problem hiding this comment.
That's a good call, thanks for linking to the commit.
@taylorotwell let me know if you want me to keep ResumeCommand or ContinueCommand.
| return isset($queue) | ||
| ? [$connection, $queue] | ||
| : [$this->laravel['config']['queue.default'], $connection]; | ||
| } |
There was a problem hiding this comment.
What about the following?
return str_contains($queue, ':')
? explode(':', $queue, 2)
: [$this->laravel['config']['queue.default'], $queue];There was a problem hiding this comment.
I don't have a strong feeling about one being better than the other. I was just hoping to move this to a trait to avoid drift between the commands.
3 participants
handle()method to avoid unnecessary construction/referencesqueue:continueand just moves it to be an alias ofResumeCommand